Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: adapt utf8mb4_0900_ai_ci collation (#10183) #10201

Merged
merged 3 commits into from
Apr 22, 2019
Merged

*: adapt utf8mb4_0900_ai_ci collation (#10183) #10201

merged 3 commits into from
Apr 22, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Apr 19, 2019 •
edited
Loading

cherry-pick #10183 to 2.1

need pingcap/parser#296 be merged before this PR, DNM

This change is Reviewable

@lysu lysu requested review from tiancaiamao and bb7133 and removed request for tiancaiamao April 19, 2019 08:45
bb7133
bb7133 reviewed Apr 19, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

pingcap/parser#296 is merged, you can update go.mod now
@lysu

@lysu lysu removed the status/DNM label Apr 22, 2019
@lysu
Copy link
Contributor Author

lysu commented Apr 22, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@lysu
Copy link
Contributor Author

lysu commented Apr 22, 2019

@tiancaiamao done~ thx

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2019
winkyao
winkyao approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 693c0a5 into pingcap:release-2.1 Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@winkyao winkyao winkyao approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lysu @tiancaiamao @bb7133 @winkyao @jackysp